Add Support for Multiservice Root DataPlane Client #9459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
jorgerangel-msft
force-pushed
the
multiservice-combined-client
branch
from
a18a014 to
7ee38f7
Compare
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
force-pushed
the
multiservice-combined-client
branch
from
7ee38f7 to
49b83b1
Compare
jorgerangel-msft
changed the title
jorgerangel-msft
requested review from
JoshLove-msft,
christothes,
jsquire and
m-nash
as code owners
jorgerangel-msft
changed the title
| } | ||
|
|
||
| return _apiVersionFields.FirstOrDefault( | ||
| f => string.Equals(f.ServiceNamespace, serviceNamespace, StringComparison.OrdinalIgnoreCase))?.Field; |
Contributor
There was a problem hiding this comment.
nit: use == as it is equivalent
| } | ||
|
|
||
| private IReadOnlyList<FieldProvider> BuildAdditionalClientFields() | ||
| private List<FieldProvider> BuildAdditionalClientFields() |
Contributor
There was a problem hiding this comment.
Is this change used somewhere?
JoshLove-msft
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for another multiservice client scenario where operations exist directly on the root client and not sub-clients.
contributes to: #9032