fix(workflow): avoid skipping CI for same-repo PRs from unbuilt branches#3003
Open
fix(workflow): avoid skipping CI for same-repo PRs from unbuilt branches#3003
Conversation
The job-level `if` previously skipped all `pull_request` runs for same-repo PRs, assuming a `push` run already covered the head SHA. But the `push` filter only matches `main`, `rel/*`, and `dev/**`, so same-repo PRs from other head branches (e.g. `feature/*`) ended up with no CI at all. Only skip when the head branch is actually covered by `push.branches`. Also scope the concurrency group by head repo + PR number for `pull_request` events so two forks pushing branches with the same name do not cancel each other.
mkrueger
previously approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the primary GitHub Actions workflow to ensure CI is not accidentally skipped for same-repo pull requests whose head branches are not covered by the workflow’s push.branches filters, and to prevent concurrency collisions between forks.
Changes:
- Refines the job-level
ifcondition so same-repo PRs are only skipped when a correspondingpushbuild would have run for that head branch. - Adjusts the
concurrency.groupforpull_requestevents to include head repo + PR number, avoiding cross-fork cancellations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job-level
ifpreviously skipped allpull_requestruns for same-repo PRs, assuming apushrun already covered the head SHA. But thepushfilter only matchesmain,rel/*, anddev/**, so same-repo PRs from other head branches (e.g.feature/*) ended up with no CI at all. Only skip when the head branch is actually covered bypush.branches.Also scope the concurrency group by head repo + PR number for
pull_requestevents so two forks pushing branches with the same name do not cancel each other.