Skip to content

fix: outdated sample versions#337

Draft
rzhao271 wants to merge 1 commit into
mainfrom
rzhao271/fix-tests
Draft

fix: outdated sample versions#337
rzhao271 wants to merge 1 commit into
mainfrom
rzhao271/fix-tests

Conversation

@rzhao271
Copy link
Copy Markdown
Contributor

No description provided.

@rzhao271 rzhao271 self-assigned this May 14, 2026
@rzhao271 rzhao271 added this to the 1.121.0 milestone May 14, 2026
@rzhao271
Copy link
Copy Markdown
Contributor Author

@copilot Check what runTests does and why it is unable to close VS Code or the unresponsive extension host after.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

@copilot Check what runTests does and why it is unable to close VS Code or the unresponsive extension host after.

runTests (in lib/runTest.ts) just spawns VS Code and waits for that process to emit exit/close. It only actively closes VS Code when the parent process receives SIGINT (Ctrl+C): first Ctrl+C sends SIGINT to VS Code, second Ctrl+C force-kills the process tree. If VS Code/extension host becomes unresponsive on its own, there is no built-in timeout/watchdog in runTests, so the promise can hang waiting for process exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants