Add make_bstr*(std::wstring_view)#634
Merged
dunhor merged 12 commits intoJul 8, 2026
Merged
Conversation
dmachaj
approved these changes
May 9, 2026
jonwis
approved these changes
May 10, 2026
dunhor
reviewed
May 11, 2026
dunhor
reviewed
May 11, 2026
chwarr
reviewed
May 19, 2026
Member
Author
|
/azp run |
jonwis
approved these changes
Jul 6, 2026
dunhor
reviewed
Jul 6, 2026
dunhor
reviewed
Jul 6, 2026
dunhor
reviewed
Jul 6, 2026
dunhor
reviewed
Jul 6, 2026
dunhor
reviewed
Jul 6, 2026
Co-authored-by: Duncan Horn <40036384+dunhor@users.noreply.github.com>
Co-authored-by: Duncan Horn <40036384+dunhor@users.noreply.github.com>
Co-authored-by: Duncan Horn <40036384+dunhor@users.noreply.github.com>
Co-authored-by: Duncan Horn <40036384+dunhor@users.noreply.github.com>
Co-authored-by: Duncan Horn <40036384+dunhor@users.noreply.github.com>
Member
Author
|
Incorporated feedback and fixed tests. Need approval of latest commits |
jonwis
approved these changes
Jul 7, 2026
dunhor
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIL only provides only PCWSTR overloads:
This PR adds
wstring_viewoverloads callingSysAllocStringLenwith the view's data and size directly, correctly handling non-null-terminated string viewsThis works for non-null-terminated views (substrings, slices), avoids unnecessary and dangerous wcslen walk (we know the wstring_view's length), and is a strict superset of the existing API.
NOTE: A
PCWSTRimplicitly converts towstring_view, so these new overloads could replace the existing ones once C++17 is the floor. WIL still supports older standards, so these additional overloads is safer.