Verify installed version matches upgrade target after installer success#6097
Open
AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
Open
Verify installed version matches upgrade target after installer success#6097AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
Conversation
When upgrading, compare the version reported by Windows (ARP correlation or MSIX package family registration) to the manifest package version after the installer exits successfully. If the installed version is still lower, emit APPINSTALLER_CLI_ERROR_UPGRADE_INSTALLED_VERSION_MISMATCH. Skips verification when reboot is required to finish (version may not update until restart) or when either version is unknown. Does not cover installers that do not participate in ARP/MSIX correlation (e.g. some portable flows); those remain unchanged. Related: microsoft#4550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to misleading success output when an upgrade exits 0 but Windows still reports an older installed version (see #4550 and related reports).
Behavior
After a successful installer return code, if the operation is an upgrade (
InstallerExecutionUseUpdate):Utility::Versionof the correlated installed version to the manifest package version. If the installed version sorts less than the expected (manifest) version, fail withAPPINSTALLER_CLI_ERROR_UPGRADE_INSTALLED_VERSION_MISMATCH(0x8A15008F).Deployment::GetInstalledVersionStringForFamilyNamewhere applicable.Notes
Portable/zip flows that do not correlate to ARP/MSIX are unchanged.
Testing
CI / AppInstallerCLITests as usual.
Made with Cursor
Microsoft Reviewers: Open in CodeFlow