Skip to content

Add supported Workbench surface profile - #26

Merged
mikeylong merged 1 commit into
mainfrom
codex/workbench-surface-profile-spike
Aug 9, 2026
Merged

Add supported Workbench surface profile#26
mikeylong merged 1 commit into
mainfrom
codex/workbench-surface-profile-spike

Conversation

@mikeylong

Copy link
Copy Markdown
Owner

What changed

This promotes the reviewed Workbench direction into a supported, versioned JudgmentKit surface-presentation profile.

  • Adds judgmentkit.workbench.operational-v1 to the public package, MCP, compiled frontend context, and design-system exports.
  • Selects it automatically only for explicitly supplied or medium/high-confidence Workbench surfaces, while preserving low-confidence fallback and external design-system boundaries.
  • Publishes the profile catalog and adds it to the existing Patterns page.
  • Preserves the reviewed specimen, ADR, release notes, and a single 0.7.0 eval run as supporting evidence.
  • Carries surface-confidence lineage through the real workflow-to-handoff path so a neutral fallback cannot gain the profile downstream.

Why

The Workbench specimen established a useful compact, flat, evidence-adjacent direction. This change makes that direction available when JudgmentKit selects a grounded Workbench without turning the specimen into a renderer, changing surface classification, or expanding the component library yet.

Verification

  • npm test — passed, including 8/8 behavioral evals
  • npm run site:build — passed
  • npm run demo:model-ui — regenerated with no drift
  • npm run eval:ui — 2/2 guided wins, zero failed thresholds
  • Focused MCP, handoff, Workbench profile, site, installed-package, and hosted-export verifier tests — passed
  • git diff --cached --check — passed before commit

Boundaries

  • No reusable Workbench component or runtime renderer is added.
  • Low-confidence fallback classification never activates the profile, including through a ready handoff or exact-ID request.
  • External design systems remain authoritative and receive no implicit JudgmentKit profile.
  • Accessibility, browser, responsive, and content-stress evidence remains required for each rendered consumer.

@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
judgmentkit-ai Ready Ready Preview Aug 9, 2026 4:10am

@mikeylong
mikeylong merged commit f679a24 into main Aug 9, 2026
5 checks passed
@mikeylong
mikeylong deleted the codex/workbench-surface-profile-spike branch August 9, 2026 04:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 807d4e5961

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.mjs
Comment on lines +13453 to +13454
const selectedSurfaceType =
providedSurfaceType ?? handoffSurfaceType ?? reviewedSurfaceType;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include handoff guidance in surface selection

When a ready handoff carries its surface selection only in surface_guidance.recommended_surface_type—without duplicating it in the top-level surface_type, as can occur with externally assembled or older handoffs—selectedSurfaceType remains null. The subsequent conflict check then treats the handoff guidance itself as conflicting and rejects an otherwise usable handoff. Include handoffGuidanceSurfaceType in this fallback chain so the guidance lineage accepted below can actually supply the selected surface.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant