Add supported Workbench surface profile - #26
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 807d4e5961
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const selectedSurfaceType = | ||
| providedSurfaceType ?? handoffSurfaceType ?? reviewedSurfaceType; |
There was a problem hiding this comment.
Include handoff guidance in surface selection
When a ready handoff carries its surface selection only in surface_guidance.recommended_surface_type—without duplicating it in the top-level surface_type, as can occur with externally assembled or older handoffs—selectedSurfaceType remains null. The subsequent conflict check then treats the handoff guidance itself as conflicting and rejects an otherwise usable handoff. Include handoffGuidanceSurfaceType in this fallback chain so the guidance lineage accepted below can actually supply the selected surface.
Useful? React with 👍 / 👎.
What changed
This promotes the reviewed Workbench direction into a supported, versioned JudgmentKit surface-presentation profile.
judgmentkit.workbench.operational-v1to the public package, MCP, compiled frontend context, and design-system exports.Why
The Workbench specimen established a useful compact, flat, evidence-adjacent direction. This change makes that direction available when JudgmentKit selects a grounded Workbench without turning the specimen into a renderer, changing surface classification, or expanding the component library yet.
Verification
npm test— passed, including 8/8 behavioral evalsnpm run site:build— passednpm run demo:model-ui— regenerated with no driftnpm run eval:ui— 2/2 guided wins, zero failed thresholdsgit diff --cached --check— passed before commitBoundaries