Skip to content

Add kms enable and rotate key actions#247

Open
reivaj05 wants to merge 3 commits into
minio:mainfrom
reivaj05:add-kms-enable-action
Open

Add kms enable and rotate key actions#247
reivaj05 wants to merge 3 commits into
minio:mainfrom
reivaj05:add-kms-enable-action

Conversation

@reivaj05

@reivaj05 reivaj05 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added support for defining KMS enable and key rotation actions in policy configurations.

@reivaj05
reivaj05 requested a review from harshavardhana July 22, 2026 18:29
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@reivaj05, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a57fa25d-86bb-4b8e-b45e-107f0aa3e95e

📥 Commits

Reviewing files that changed from the base of the PR and between a286bdd and 3932d1a.

📒 Files selected for processing (1)
  • policy/kms-action.go
📝 Walkthrough

Walkthrough

Adds exported constants for kms:Enable and kms:KeyRotate to the KMSAction set. The provided change does not update the validity map used by KMSAction.IsValid().

Changes

KMS action declarations

Layer / File(s) Summary
Add KMS action constants
policy/kms-action.go
Adds KMSEnableAction and KMSKeyRotateAction to the exported KMSAction constants.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • minio/pkg#246: Updates the typing of existing KMS action constants in the same file.

Suggested reviewers: harshavardhana

Poem

A bunny found two actions bright,
Enable and rotate, named just right.
Through policy’s code they softly hop,
Yet validity’s map still says stop.
“Add them there too!” the rabbit cried,
Then tucked its ears and bounced outside.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the added KMS enable and key rotate actions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@policy/kms-action.go`:
- Around line 66-69: Update the GoDoc comments for the exported constants
KMSEnableAction and KMSKeyRotateAction to use sentence style, starting with each
identifier and ending with a period; describe KMS as “built-in” where
applicable.
- Around line 66-69: Update the supportedKMSActions registry to include both
KMSEnableAction and KMSKeyRotateAction, ensuring KMSAction.IsValid() and
statement validation recognize these constants as valid KMS actions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3748e26f-5937-41ad-94dd-61ed85b43a53

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac0e36 and a286bdd.

📒 Files selected for processing (1)
  • policy/kms-action.go

Comment thread policy/kms-action.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants