Export: preserve Dtype state values in export callback arguments#3145
Merged
awni merged 3 commits intoml-explore:mainfrom Feb 19, 2026
Merged
Export: preserve Dtype state values in export callback arguments#3145awni merged 3 commits intoml-explore:mainfrom
awni merged 3 commits intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes export callback state serialization for primitives that include
Dtypein their state (for exampleAsType), so callbackargumentspreserve dtype values instead of dropping them.Add explicit handling for Dtype during state unpacking:
It also adds a regression test to validate callback behavior and updates export docs with callback payload details.
Problem
In mlx/export.cpp, the state unpacking logic did not handle Dtype in tuple/variant flattening.
As a result, primitives with dtype state (for example AsType, NumberOfElements) could emit incomplete arguments during export.
Why this is needed
Downstream IR/export consumers rely on complete primitive arguments. Missing dtype state breaks robust graph export/lowering paths and forces downstream inference fallbacks.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes