added sub components to bias components - #35
Open
surbhir08 wants to merge 2 commits into
Open
Conversation
brownsarahm
requested changes
Jul 27, 2026
brownsarahm
left a comment
brownsarahm
left a comment
Collaborator
There was a problem hiding this comment.
needs a few small changes (I have not yet run it though)
Comment on lines
+327
to
+340
| ''' | ||
| sample P(X|A) using distribution and parameters initialized for | ||
| a. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| a : list-like length n | ||
| demographic variables | ||
|
|
||
| Returns | ||
| -------- | ||
| x : list like, length n | ||
| featuers, same shape as a | ||
| ''' |
Collaborator
There was a problem hiding this comment.
move this to the function, not the class
| x = np.asarray(x) | ||
|
|
||
| return x | ||
| ###### |
|
|
||
| ############ | ||
|
|
||
| class FeatureConditionerA(Feature): |
Collaborator
There was a problem hiding this comment.
The conditioners should not inherit fromFeature, they should have only the sample method
|
|
||
| mvn = lambda mu,var :np.random.multivariate_normal(mu,var*np.eye(len(mu))) | ||
|
|
||
| class FeatureSharedParam(Feature): |
Collaborator
There was a problem hiding this comment.
the parameter mixins won't inherit from Feature anymore either, they should have only a constructor.
Co-authored-by: Sarah Brown <brownsarahm@uri.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.