fix: launch android emulator with netspeed full, netdelay none and qt-no-window

[gmegidish]

Summary by CodeRabbit

• Improvements
  • Android emulator now launches with optimized network configuration settings, enhancing performance during testing workflows.
  • Emulator window automatically hides during startup for a streamlined user interface.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The Boot() function in devices/android.go is modified to launch the emulator with additional configuration flags: network delay and speed settings, window hiding, and explicit AVD identification.

Changes

Cohort / File(s)	Summary
Emulator boot configuration devices/android.go	Modified Boot() to include additional emulator launch flags: -netdelay none, -netspeed full, -qt-hide-window, and explicitly append -avd d.id for AVD identification during startup

Possibly related PRs

• feat: removed -no-snapshot-load and added -no-window #117: Also modifies emulator launch flags in devices/android.go's Boot() function with changes to how the emulator is started

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding network configuration flags (netspeed full, netdelay none) and window hiding (-qt-no-window) to the Android emulator launch in Boot().
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-use-qt-no-window

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

devices/android.go (1)

535-538: Emulator flags align with docs; please verify -qt-hide-window support and consider minor CLI polish

This command matches the documented pattern Android Studio now uses (-netdelay none, -netspeed full, -qt-hide-window), and explicitly setting the network to none/full is fine even though those are the defaults. (developer.android.com)

Two small points to double‑check:

1. Compatibility of -qt-hide-window
   Older Android Emulator versions can fail with unknown option: -qt-hide-window, so this change effectively raises the minimum required emulator version for anyone using mobilecli. (stackoverflow.com)
   If you still need to support older SDKs, consider:

   • Documenting the minimum emulator version required, or
   • Making -qt-hide-window configurable (env flag / CLI option) or falling back to a launch without it on failure.

2. Optional ordering tweak
   Docs show the canonical syntax as emulator -avd <name> [options...]. Reordering to put -avd d.id immediately after getEmulatorPath() would more closely mirror the official examples, though it’s not strictly required for correctness:
   exec.Command(getEmulatorPath(), "-avd", d.id, "-netdelay", "none", "-netspeed", "full", "-qt-hide-window"). (developer.android.com)

Functionally this looks good; the comment is mainly about environment compatibility and a small readability polish.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38fdc5b and 50d833b.

📒 Files selected for processing (1)

• devices/android.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: lint
• GitHub Check: Analyze (go)