Skip to content

Add pre-commit check for private registry URLs in package-lock.json #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ochafik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add pre-commit check for private registry URLs in package-lock.json #133

ochafik wants to merge 1 commit into from

Conversation

@ochafik
Copy link
Collaborator

@ochafik ochafik commented Dec 11, 2025

Summary

  • Adds a pre-commit hook check that mirrors the CI check for private registry URLs
  • Catches Artifactory URLs before push, avoiding CI failures

Test plan

  • Tested locally: hook correctly rejects package-lock.json with non-npmjs.org URLs

🤖 Generated with Claude Code

@ochafik @claude
Add pre-commit check for private registry URLs in package-lock.json
32d08f2 
Same check as in CI to catch issues before push.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/ext-apps/@modelcontextprotocol/ext-apps@133

commit: 32d08f2

ochafik added a commit that referenced this pull request Dec 11, 2025
@ochafik @claude
Revert pre-commit artifactory check (moved to separate PR #133)
277a004 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@ochafik ochafik requested a review from antonpk1 December 11, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanhefner jonathanhefner Awaiting requested review from jonathanhefner

@antonpk1 antonpk1 Awaiting requested review from antonpk1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ochafik