fix: clean up idle streamable HTTP sessions - #1087
Open
steven-ji wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional, backward-compatible idle timeout to
HttpServletStreamableServerTransportProvider.The timeout is disabled by default. When configured, the provider records session
activity and expires only sessions that have remained genuinely idle beyond the
configured timeout. Active requests and open SSE streams keep their sessions alive.
Motivation and Context
Streamable HTTP sessions currently remain in the provider session map until the
client sends an explicit
DELETErequest or the provider shuts down. Clients candisconnect, restart, or fail without sending
DELETE, causing abandoned sessionsto accumulate indefinitely.
This implements the TTL and recency-marker approach discussed in #471 while
preserving the existing default behavior.
Fixes #471
How Has This Been Tested?
./mvnw -pl mcp-core clean testgit diff --check origin/main...HEADThe validation claim is limited to the
mcp-coremodule; no successfulfull-reactor test result is claimed.
Breaking Changes
None. Idle cleanup remains disabled unless
sessionTimeoutis explicitlyconfigured, and existing builder usage retains its previous behavior.
Types of changes
Checklist
Additional context
maxSessionslimit are outside this PR.disclosure.txtis included as required by the repository contribution policy.