fix: skip deprecated/deleted servers in URL uniqueness check (#1193)#1343
Open
friendlygeorge wants to merge 2 commits into
Open
fix: skip deprecated/deleted servers in URL uniqueness check (#1193)#1343friendlygeorge wants to merge 2 commits into
friendlygeorge wants to merge 2 commits into
Conversation
added 2 commits
June 8, 2026 09:43
…ntextprotocol#1193) validateNoDuplicateRemoteURLs was blocking URL reuse when the existing server was deprecated or deleted. Added a Status filter to ServerFilter to allow callers to specify which statuses to match, and updated the validation logic to only check active servers. Changes: - Add Status field to ServerFilter struct - Update postgres query builder to handle Status filter - Filter by active status in validateNoDuplicateRemoteURLs - Add test case for deprecated server URL reuse
… UpdateAllVersionsStatus with StatusChangeRequest)
Author
|
CI is now passing after updating the test to use the renamed function with the new signature. Both Build/Lint and Tests pass. Ready for review. |
Author
|
Hi — just checking in on this. Happy to iterate on the approach, split the PR, or adjust the implementation based on any feedback. Let me know if there's anything I can clarify or improve. |
Author
|
Hi, just checking in on this. Happy to iterate on the approach or split the PR if it'd be easier to review. Let me know if there's anything I can clarify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
was blocking URL reuse when the existing server was deprecated or deleted. This fix adds a filter to and updates the validation logic to only check active servers.
Changes
Issue
Fixes #1193 — deprecated servers should not block URL reuse by new active servers.
Testing
Added test case that creates a deprecated server, then verifies a new server can reuse its URL.