fix: avoid DOM-only HeadersInit in v1 declarations - #2570
Open
kocaemre wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 6b74bc7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the v1 declaration output so Node-only TypeScript projects do not need the DOM lib just to consume
normalizeHeaders.The generated
shared/transport.d.tscurrently exposes the bare globalHeadersInit, which is not provided by@types/nodeeven when Node fetch globals are enabled. This changes the public signature toRequestInit['headers'], matching the same runtime inputs without pulling in a DOM-only alias.Also updates two internal client header annotations for the same reason and adds a patch changeset.
Verification
npm run build:esm npm run build:cjs npm run typecheck npm run lint npm test -- test/client/sse.test.ts test/client/streamableHttp.test.tsNode-only declaration smoke test:
Result:
npx tsc -p tsconfig.jsonpasses.Fixes #2568