Minor improvements/additiona to enviroments section #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- slight consistency improvments - mention how to create enviroments explicitly - explicit recommendation to use project-specific, local enviroments
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just linked this section about enviroments in a discourse thread which caused me to read it again. I noticed a couple of small things, that I address in this PR.
I saw 3 places where I think consistency could be improved slightly.
Additionally, I realized we never explicitly mention how environments are created (only that they can be activated), so I added a sentence to clarify.
Furthermore, I felt like the recommendation to not litter the global environment could be complemented by stating explicitly that having many local enviroments, i.e. one for each project, is the recommended way. This was implied before but stating it explicitly makes it even more beginner-friendly I think.
Of course, all of these are just suggestions, so feel to make of them what you like.
Thank you for MoJuWo and happy new year!