Output preimage after successful payment#28
Conversation
f3r10
commented
Feb 12, 2026
f3r10
commented
- Added PaymentResult NAPI struct with payment_hash: String and preimage: Option
- Changed wait_for_payment_outcome to extract payment_preimage from Event::PaymentSuccessful and return Option instead of ()
- Changed pay(), payWhileRunning(), and execute_payment_impl() return type from String to PaymentResult
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6e2f15852
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17a1bc023c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ubuntu-latest now ships Docker 29.x (min API 1.44) which breaks addnab/docker-run-action@v3's docker:20.10 client (API 1.41).
addnab/docker-run-action@v3 uses docker:20.10 (API 1.41) which is incompatible with Docker 29.x (min API 1.44) now shipped on all GitHub-hosted Ubuntu runners since Feb 9 2026. Ref: actions/runner-images#13474
PaymentResult now always includes payment_id so callers can track async BOLT12 payments even without wait_secs. Previously, BOLT12 payments returned an empty PaymentResult with no tracking identifier. Also removes preimage from stderr logs - it's sensitive payment proof material that shouldn't be in logs. Still returned via the API.
martinsaposnic
force-pushed
the
mdk-537
branch
from
17a1bc0 to
44bdd9f
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
