Skip to content

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 14, 2026

PYTHON-5696

Changes in this PR

Update backpressure-network sdam tests to avoid race condition with server heartbeats between members of a replica_set. Testing for mongodb/specifications#1880.

Test Plan

Standard tests

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@blink1073 blink1073 requested a review from a team as a code owner January 14, 2026 14:43
@blink1073 blink1073 requested review from aclark4life and removed request for a team January 14, 2026 14:43
@blink1073
Copy link
Member Author

Test failures are unrelated, I need to update the backpressure branch

@blink1073
Copy link
Member Author

The integration and static checks will be fixed by #2635

@aclark4life
Copy link
Contributor

How does this avoid the race condition?

@blink1073
Copy link
Member Author

blink1073 commented Jan 21, 2026

How does this avoid the race condition?

We wait for the server topology to get into a known state before adding the failCommand, to avoid the case where we haven't connected to all of the servers yet.

Copy link
Contributor

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit 27a9f47 into mongodb:backpressure Jan 21, 2026
76 of 80 checks passed
@blink1073 blink1073 deleted the PYTHON-5696 branch January 21, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants