Skip to content

test(NODE-7400): Test Node Driver 7.0.0 against latest version of BSON library#4853

Merged
baileympearson merged 17 commits intomongodb:mainfrom
PavelSafronov:NODE-7400
Feb 2, 2026
Merged

test(NODE-7400): Test Node Driver 7.0.0 against latest version of BSON library#4853
baileympearson merged 17 commits intomongodb:mainfrom
PavelSafronov:NODE-7400

Conversation

@PavelSafronov
Copy link
Contributor

@PavelSafronov PavelSafronov commented Jan 29, 2026

Description

Summary of Changes

Test Node Driver 7.0.0 against latest version of BSON library

Notes for Reviewers

We now have log state task which logs the current commit hash (so we know what version of Driver we are running) and npm ls (so we know what packages we are using).

Here is a task where we pull in v7.1.0 of BSON (the problematic version): https://spruce.mongodb.com/version/697be2a8be7ae60007d93c39/
The new task fails as expected: https://spruce.mongodb.com/task/mongo_node_driver_next_BSON_compatibility_tests_test_bson_latest_server_7.0.0_patch_0358360b6f2c8cf045b05240169171c83192faf1_697be2a8be7ae60007d93c39_26_01_29_22_44_00/html-log?execution=0&origin=task#L437

Exception during run: TypeError: Cannot read properties of undefined (reading 'getInt32LE')

What is the motivation for this change?

BSON 7.0.1 ended up breaking Driver, but we only found out when we released that version.
This task will run the latest version of BSON (most recent commit) against Node Driver v7.0.0

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov marked this pull request as ready for review January 29, 2026 22:52
@PavelSafronov PavelSafronov requested a review from a team as a code owner January 29, 2026 22:52
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, plus discussion from team channel about running integration tests as well

@baileympearson baileympearson self-assigned this Jan 30, 2026
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 30, 2026
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor change. otherwise LGTM

PavelSafronov and others added 2 commits February 2, 2026 08:25
Co-authored-by: Bailey Pearson <bailey.pearson@gmail.com>
@baileympearson baileympearson dismissed dariakp’s stale review February 2, 2026 18:36

Daria has given slack approval to merge

@baileympearson baileympearson merged commit 9151d48 into mongodb:main Feb 2, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants