Conversation
* new runtime in serverless.yml definition * removed check-engine for now so it works at all with new versions * fixed pack npm script (install failed because production flag) * rebuilt package-lock.json
|
@mooyoul Thank you for your feedback. I improved the PR and made the change less breaking. |
mooyoul
left a comment
mooyoul
left a comment
There was a problem hiding this comment.
Thanks for your contribution 👍 but there are some requests to approve -
package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": "^8.10.0", | ||
| "node": ">= v12.0", |
There was a problem hiding this comment.
Please remove v character. and use full semver version. See https://github.com/npm/node-semver for details.
| "node": ">= v12.0", | |
| "node": ">= 12.0.0", |
There was a problem hiding this comment.
and Please update check-engine dependency ;)
* 12.x as major version requirement * also updated check-engine dependency
|
Updated the check-engine dependency and used |
2 participants
check-enginefor now, so it works at all with new versionsnpm lsprobably changed)package-lock.jsonThese were the changes for me to get it to work as a new deployment. Your mileage may vary.
I'm open to suggestion changes and feedback on the PR. Maybe someone has an idea how to fix the check-engine config first instead of disabling it e.g.