refactor: rename MPTFork hardfork to Jade

[chengwenxi]

Resolves: #30

Summary by CodeRabbit

• Refactor
  • Updated hardfork terminology to use Jade as the primary timestamp-based activation mechanism for Morph hardforks.
  • Renamed hardfork activation checks and configuration references to reflect Jade naming conventions.
  • Adjusted hardfork activation logic to prioritize Jade-based timing for state root validation.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR systematically renames the MPTFork hardfork to Jade throughout the codebase. The refactoring updates struct field names (mpt_fork_time → jade_time), enum variants (MorphHardfork::MPTFork → MorphHardfork::Jade), method names (is_mpt_fork → is_jade), JSON serialization keys, and associated documentation and tests.

Changes

Cohort / File(s)	Summary
Chainspec Core Logic crates/chainspec/src/hardfork.rs, crates/chainspec/src/genesis.rs, crates/chainspec/src/spec.rs	Renamed MPTFork enum variant to Jade; field mpt_fork_time to jade_time; method is_mpt_fork to is_jade; and is_mpt_fork_active_at_timestamp to is_jade_active_at_timestamp. Updated morph_hardfork_at to prioritize Jade-based activation. Adjusted SpecId conversions and JSON serialization keys. Tests updated to reflect new naming.
Engine-API Validation crates/engine-api/src/builder.rs, crates/engine-api/src/lib.rs, crates/engine-api/src/validator.rs	Updated documentation and logic to reference Jade instead of MPTFork. Modified should_validate_state_root to delegate to is_jade_active_at_timestamp. Tests and helpers renamed from mpt_fork to jade variants; comments updated to reflect Jade semantics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 From Morph's old fork to Jade so bright,
A hardfork shines with emerald light,
Each method dons a verdant name,
Timestamp checks are just the same,
Our chainspec blooms in spring's great game! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: renaming the MPTFork hardfork to Jade, which aligns with the changeset modifications across multiple files.
Linked Issues check	✅ Passed	The PR renames MPTFork hardfork to Jade throughout the codebase, addressing the core objective of issue #30 by updating enum variants, method names, field names, and all related documentation.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the renaming objective: field/variant/method renames from MPTFork to Jade, updated tests, and documentation changes. No unrelated modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jade

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

crates/chainspec/src/spec.rs (1)

568-636: Consider adding test coverage for Jade hardfork activation.

The existing test_morph_hardfork_at test covers hardforks up to Emerald but doesn't include Jade. Since Jade is the new latest hardfork, consider adding a test case to verify morph_hardfork_at returns MorphHardfork::Jade when Jade is active.

💡 Suggested test extension

Add "jadeTime": 6000 to the genesis JSON and include:

// At Jade time (block 600, timestamp 6000)
assert_eq!(
    chainspec.morph_hardfork_at(600, 6000),
    MorphHardfork::Jade
);

// After Jade (block 700, timestamp 7000)
assert_eq!(
    chainspec.morph_hardfork_at(700, 7000),
    MorphHardfork::Jade
);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/chainspec/src/spec.rs` around lines 568 - 636, The test
test_morph_hardfork_at misses coverage for the new Jade hardfork; update the
genesis JSON used to create the MorphChainSpec (via
MorphChainSpec::from(genesis)) by adding "jadeTime": 6000 in the config and
extend the assertions calling chainspec.morph_hardfork_at(...) to check that
morph_hardfork_at(600, 6000) returns MorphHardfork::Jade and that subsequent
calls (e.g., morph_hardfork_at(700, 7000)) also return MorphHardfork::Jade so
Jade activation is validated.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@crates/chainspec/src/spec.rs`:
- Around line 568-636: The test test_morph_hardfork_at misses coverage for the
new Jade hardfork; update the genesis JSON used to create the MorphChainSpec
(via MorphChainSpec::from(genesis)) by adding "jadeTime": 6000 in the config and
extend the assertions calling chainspec.morph_hardfork_at(...) to check that
morph_hardfork_at(600, 6000) returns MorphHardfork::Jade and that subsequent
calls (e.g., morph_hardfork_at(700, 7000)) also return MorphHardfork::Jade so
Jade activation is validated.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd3d45 and 79a0d23.

📒 Files selected for processing (6)

• crates/chainspec/src/genesis.rs
• crates/chainspec/src/hardfork.rs
• crates/chainspec/src/spec.rs
• crates/engine-api/src/builder.rs
• crates/engine-api/src/lib.rs
• crates/engine-api/src/validator.rs