Conversation
Co-authored-by: allen.wu <allen.wu@bitget.com>
Upgrade github.com/morph-l2/go-ethereum from v1.10.14-0.20260227074910-324c53b65341 to v1.10.14-0.20260302105006-9e26fa129767 The new version fixes "cannot unmarshal string into Go struct field rpcBlock.transactions.version of type uint8" error that occurred when non-sequencer nodes called BlockByNumber to sync blocks containing MorphTx V1 transactions.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (40)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. Tip You can customize the high-level summary generated by CodeRabbit.Configure the ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Wrong base branch, recreating with test_3_13 as target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/morph-l2/go-ethereumfromv1.10.14-0.20260227074910-324c53b65341tov1.10.14-0.20260302105006-9e26fa129767json: cannot unmarshal string into Go struct field rpcBlock.transactions.version of type uint8Background
After MorphTx V1 was introduced, the
versionfield inRPCTransaction(api.go) was serialized as a hex string ("0x1"viahexutil.Uint64), but the client-sidetxJSON.Versionwas*uint8expecting a plain number. This causedethclient.BlockByNumberto fail on all non-sequencer nodes when syncing blocks that contain MorphTx V1 transactions.The fix in go-ethereum aligns
txJSON.Versionwith the Ethereum JSON-RPC hex encoding convention.Changes
go.mod+go.sumin:node,tx-submitter,oracle,contracts,bindings,ops/tools,ops/l2-genesis,token-price-oracleTest plan
BlockByNumbererrorsSummary by CodeRabbit
Release Notes
New Features
Refactor
Chores