fix: avoid initializing syncer at node startup in sequencer mode#917
Merged
FletcherMan merged 1 commit intorelease/0.5.xfrom Mar 16, 2026
Merged
fix: avoid initializing syncer at node startup in sequencer mode#917FletcherMan merged 1 commit intorelease/0.5.xfrom
FletcherMan merged 1 commit intorelease/0.5.xfrom
Conversation
Previously, the syncer was eagerly initialized just to reuse its L1 client for L1 sequencer components and BlockTagService. This required a deposit contract config that is unnecessary for non-validator nodes, causing mainnet nodes to fail on startup. Now we dial the L1 client directly from the l1.rpc flag and defer syncer creation to a lazy factory (newSyncerFunc) that only runs when the executor actually needs it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FletcherMan
approved these changes
Mar 16, 2026
twcctop
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the syncer was eagerly initialized just to reuse its L1 client for L1 sequencer components and BlockTagService. This required a deposit contract config that is unnecessary for non-validator nodes, causing mainnet nodes to fail on startup.
Now we dial the L1 client directly from the l1.rpc flag and defer syncer creation to a lazy factory (newSyncerFunc) that only runs when the executor actually needs it.