Allow scanners to run asynchronously and send their results later#24447
Merged
Allow scanners to run asynchronously and send their results later#24447
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
willdurand
force-pushed
the
async-scanners
branch
5 times, most recently
from
e041f2e to
de37ca6
Compare
willdurand
commented
Feb 11, 2026
willdurand
commented
Feb 11, 2026
diox
reviewed
Feb 11, 2026
| return Response(status=status.HTTP_404_NOT_FOUND) | ||
|
|
||
| # Verify the authenticated user is the service account for this webhook. | ||
| if request.user != scanner_result.webhook.service_account: |
Member
There was a problem hiding this comment.
If this was a class-based-view I would recommend doing this bit in a permission class (defining has_object_permission()) and just have that class in permission_classes but that doesn't work for api_view() ... It's probably fine.
willdurand
force-pushed
the
async-scanners
branch
from
de37ca6 to
3bf845a
Compare
Member
Author
|
(depends on #24462) |
willdurand
force-pushed
the
async-scanners
branch
from
3bf845a to
571e727
Compare
Member
Author
|
(rebase) |
diox
reviewed
Feb 17, 2026
willdurand
force-pushed
the
async-scanners
branch
from
571e727 to
3b6fb92
Compare
diox
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16004
This PR lets scanners (webhooks) push their results async.