Remove Firefox pages and assets migrated to springfield #17264
Open
stephaniehobson wants to merge 3 commits into
Open
Remove Firefox pages and assets migrated to springfield #17264stephaniehobson wants to merge 3 commits into
stephaniehobson wants to merge 3 commits into
Conversation
stephaniehobson
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy Bedrock-rendered Firefox marketing/pages (templates, Fluent resources, and front-end assets) that have been migrated to www.firefox.com (“Springfield”), and keeps legacy named URL routes reversible by redirecting them to Firefox.com instead of rendering locally.
Changes:
- Deleted Firefox page templates/FTL files and associated CSS/JS that are no longer served by Bedrock.
- Added/updated redirect behavior to send deprecated Bedrock Firefox paths to www.firefox.com (and AMO for Facebook Container).
- Removed the Firefox sub-navigation include from remaining pages and cleaned up related navigation references.
Reviewed changes
Copilot reviewed 148 out of 149 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| profiling/hit_popular_pages.py | Drops a now-deprecated Firefox campaign URL from the “popular pages” list. |
| package-lock.json | Lockfile metadata update (marks fsevents as dev dependency). |
| media/js/firefox/set-as-default/thanks.js | Removed JS tied to deleted “set as default” thanks page. |
| media/js/firefox/nothing-personal/random-answers.es6.js | Removed JS for deleted “nothing personal” campaign page. |
| media/js/firefox/nothing-personal/fx-is-default-init.es6.js | Removed JS init for deleted “nothing personal” campaign page. |
| media/js/firefox/nothing-personal/animations.es6.js | Removed animations JS for deleted “nothing personal” campaign page. |
| media/js/firefox/features/features-article.es6.js | Removed features-article JS tied to deleted feature article templates. |
| media/js/firefox/enterprise/landing.js | Removed enterprise landing JS now served elsewhere. |
| media/js/firefox/challenge-the-default/device-detect.es6.js | Removed CTD device detection JS for deleted CTD pages. |
| media/js/firefox/challenge-the-default/animate-pop-in.es6.js | Removed CTD animation JS for deleted CTD pages. |
| media/css/firefox/set-as-default/thanks.scss | Removed styling for deleted “set as default” thanks page. |
| media/css/firefox/set-as-default/landing.scss | Removed styling for deleted “set as default” landing page. |
| media/css/firefox/nothing-personal/_sticky-note.scss | Removed styling for deleted “nothing personal” campaign page. |
| media/css/firefox/nothing-personal/_primary-cta.scss | Removed CTA styling for deleted “nothing personal” campaign page. |
| media/css/firefox/nothing-personal/_header.scss | Removed header styling for deleted “nothing personal” campaign page. |
| media/css/firefox/nothing-personal/_fox-gif.scss | Removed GIF styling for deleted “nothing personal” campaign page. |
| media/css/firefox/nothing-personal/_fonts.scss | Removed campaign-specific font-face declarations for deleted “nothing personal” page. |
| media/css/firefox/nothing-personal/_feature-box.scss | Removed feature-box styling for deleted “nothing personal” page. |
| media/css/firefox/nothing-personal/_browser.scss | Removed “browser chrome” styling for deleted “nothing personal” page. |
| media/css/firefox/nothing-personal/_animations.scss | Removed animation styling for deleted “nothing personal” page. |
| media/css/firefox/more/misinformation.scss | Removed misinformation page styling (page migrated/removed). |
| media/css/firefox/features/tips.scss | Removed styling for deleted Firefox tips pages. |
| media/css/firefox/features/picture-in-picture.scss | Removed styling for deleted PiP feature page. |
| media/css/firefox/features/index.scss | Removed styling for deleted Firefox features index pages. |
| media/css/firefox/features/article.scss | Removed styling for deleted Firefox features article base/templates. |
| media/css/firefox/facebook-container.scss | Removed styling for deleted Facebook Container page. |
| media/css/firefox/channel.scss | Removed styling for deleted channel pages. |
| media/css/firefox/challenge-the-default/_toggle.scss | Removed styling for deleted CTD toggle component. |
| l10n/en/firefox/set-as-default/thanks.ftl | Removed Fluent strings for deleted “set as default” thanks page. |
| l10n/en/firefox/set-as-default/landing.ftl | Removed Fluent strings for deleted “set as default” landing page. |
| l10n/en/firefox/more/misinformation.ftl | Removed Fluent strings for removed misinformation page. |
| l10n/en/firefox/more.ftl | Removed Fluent strings for removed /firefox/more/ page. |
| l10n/en/firefox/features/translate.ftl | Removed Fluent strings for removed translate feature page. |
| l10n/en/firefox/features/sync-2023.ftl | Removed Fluent strings for removed sync feature page. |
| l10n/en/firefox/features/shared.ftl | Removed shared Fluent strings for removed features article base. |
| l10n/en/firefox/features/private-browsing-2023.ftl | Removed Fluent strings for removed private browsing page. |
| l10n/en/firefox/features/private-2023.ftl | Removed Fluent strings for removed “private” feature page. |
| l10n/en/firefox/features/pinned-tabs-2023.ftl | Removed Fluent strings for removed pinned tabs feature page. |
| l10n/en/firefox/features/picture-in-picture.ftl | Removed Fluent strings for removed PiP feature page. |
| l10n/en/firefox/features/pdf-editor-2023.ftl | Removed Fluent strings for removed PDF editor feature page. |
| l10n/en/firefox/features/password-manager-2023.ftl | Removed Fluent strings for removed password manager feature page. |
| l10n/en/firefox/features/index-2023.ftl | Removed Fluent strings for removed features index page. |
| l10n/en/firefox/features/fingerprinting.ftl | Removed Fluent strings for removed fingerprinting feature page. |
| l10n/en/firefox/features/fast-2024.ftl | Removed Fluent strings for removed “fast” feature page variant. |
| l10n/en/firefox/features/fast-2023.ftl | Removed Fluent strings for removed “fast” feature page variant. |
| l10n/en/firefox/features/eyedropper-2023.ftl | Removed Fluent strings for removed eyedropper feature page. |
| l10n/en/firefox/features/customize-2023.ftl | Removed Fluent strings for removed customize feature page. |
| l10n/en/firefox/features/bookmarks-2023.ftl | Removed Fluent strings for removed bookmarks feature page. |
| l10n/en/firefox/features/add-ons-2023.ftl | Removed Fluent strings for removed add-ons feature page. |
| l10n/en/firefox/features/adblocker-2025.ftl | Removed Fluent strings for removed adblocker (2025) page. |
| l10n/en/firefox/facebook_container.ftl | Removed Fluent strings for removed Facebook Container page. |
| l10n/en/firefox/enterprise.ftl | Removed Fluent strings for removed enterprise page. |
| l10n/en/firefox/channel.ftl | Removed Fluent strings for removed channel pages. |
| bedrock/mozorg/templates/mozorg/home/includes/ctd-promo-de.html | Removed the DE-only CTD promo include (no longer referenced). |
| bedrock/mozorg/templates/mozorg/home/home-new.html | Removes conditional include of the deleted DE CTD promo. |
| bedrock/foundation/templates/foundation/annualreport/2017/index.html | Replaces internal route link with direct AMO link for Facebook Container. |
| bedrock/firefox/views.py | Adds fxc_redirect fallback view and removes now-dead feature view code. |
| bedrock/firefox/tests/test_views.py | Removes skipped test for deleted “set as default” thanks template. |
| bedrock/firefox/templates/firefox/set-as-default/thanks.html | Deleted template for removed “set as default” thanks page. |
| bedrock/firefox/templates/firefox/set-as-default/landing.html | Deleted template for removed “set as default” landing page. |
| bedrock/firefox/templates/firefox/nothing-personal/includes/browser-macro.html | Deleted macro include for removed “nothing personal” page. |
| bedrock/firefox/templates/firefox/new/desktop/firefox-new-refresh.html | Removes Firefox sub-nav include from this page. |
| bedrock/firefox/templates/firefox/new/desktop/download.html | Removes Firefox sub-nav include from this page. |
| bedrock/firefox/templates/firefox/landing/gaming.html | Removes Firefox sub-nav include from this page. |
| bedrock/firefox/templates/firefox/landing/education.html | Removes Firefox sub-nav include from this page. |
| bedrock/firefox/templates/firefox/includes/sub-nav-firefox.html | Deletes the shared Firefox sub-navigation include. |
| bedrock/firefox/templates/firefox/firefox-20th/index.html | Removes Firefox sub-nav include from this page. |
| bedrock/firefox/templates/firefox/features/translate.html | Deleted template for removed translate feature page. |
| bedrock/firefox/templates/firefox/features/tips/includes/pip-tina.html | Deleted include for removed tips content. |
| bedrock/firefox/templates/firefox/features/tips/includes/password-nneka.html | Deleted include for removed tips content. |
| bedrock/firefox/templates/firefox/features/tips/includes/forget-damiano.html | Deleted include for removed tips content. |
| bedrock/firefox/templates/firefox/features/tips/includes/eyedropper-bram.html | Deleted include for removed tips content. |
| bedrock/firefox/templates/firefox/features/sync.html | Deleted template for removed sync feature page. |
| bedrock/firefox/templates/firefox/features/private.html | Deleted template for removed private feature page. |
| bedrock/firefox/templates/firefox/features/private-browsing.html | Deleted template for removed private browsing feature page. |
| bedrock/firefox/templates/firefox/features/pinned-tabs.html | Deleted template for removed pinned tabs feature page. |
| bedrock/firefox/templates/firefox/features/picture-in-picture.html | Deleted template for removed PiP feature page. |
| bedrock/firefox/templates/firefox/features/pdf-free-fr.html | Deleted FR PDF-related template now migrated/removed. |
| bedrock/firefox/templates/firefox/features/pdf-editor.html | Deleted template for removed PDF editor feature page. |
| bedrock/firefox/templates/firefox/features/pdf-editor-fr.html | Deleted FR PDF editor template now migrated/removed. |
| bedrock/firefox/templates/firefox/features/pdf-complete-fr.html | Deleted FR PDF-related template now migrated/removed. |
| bedrock/firefox/templates/firefox/features/password-manager.html | Deleted template for removed password manager feature page. |
| bedrock/firefox/templates/firefox/features/fingerprinting.html | Deleted template for removed fingerprinting feature page. |
| bedrock/firefox/templates/firefox/features/fast.html | Deleted template for removed “fast” feature page. |
| bedrock/firefox/templates/firefox/features/fast-2024.html | Deleted template for removed “fast” feature page variant. |
| bedrock/firefox/templates/firefox/features/eyedropper.html | Deleted template for removed eyedropper feature page. |
| bedrock/firefox/templates/firefox/features/customize.html | Deleted template for removed customize feature page. |
| bedrock/firefox/templates/firefox/features/bookmarks.html | Deleted template for removed bookmarks feature page. |
| bedrock/firefox/templates/firefox/features/base-article.html | Deleted base template for removed feature article pages. |
| bedrock/firefox/templates/firefox/features/add-ons.html | Deleted template for removed add-ons feature page. |
| bedrock/firefox/templates/firefox/features/adblocker-2025.html | Deleted template for removed adblocker (2025) page. |
| bedrock/firefox/templates/firefox/facebookcontainer/index.html | Deleted template for removed Facebook Container page. |
| bedrock/firefox/templates/firefox/facebookcontainer/includes/video.html | Deleted include for removed Facebook Container page. |
| bedrock/firefox/templates/firefox/channel/ios.html | Deleted template for removed iOS channel page. |
| bedrock/firefox/templates/firefox/channel/base.html | Deleted base template for removed channel pages. |
| bedrock/firefox/templates/firefox/channel/android.html | Deleted template for removed Android channel page. |
| bedrock/firefox/templates/firefox/challenge-the-default/langs/landing.pl.html | Deleted localized CTD landing content (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/langs/landing.it.html | Deleted localized CTD landing content (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/langs/landing.fr.html | Deleted localized CTD landing content (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/langs/landing.es-ES.html | Deleted localized CTD landing content (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/langs/landing.de.html | Deleted localized CTD landing content (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/landing-switch.html | Deleted CTD landing locale switch include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/wednesday.html | Deleted CTD include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/toggles.html | Deleted CTD include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v6.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v5.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v4.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v3.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v2.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/heroes/hero-v1.html | Deleted CTD hero variant include (page removed). |
| bedrock/firefox/templates/firefox/challenge-the-default/includes/hero.html | Deleted CTD base hero include (page removed). |
| bedrock/firefox/templates/firefox/built-for-you/includes/v5-human.html | Deleted “built-for-you” include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v4-alien.html | Deleted “built-for-you” include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v3-sloth.html | Deleted “built-for-you” include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v2-superhero-fr.html | Deleted “built-for-you” FR include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v2-superhero-de.html | Deleted “built-for-you” DE include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v1-pinocchio-fr.html | Deleted “built-for-you” FR include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/built-for-you/includes/v1-pinocchio-de.html | Deleted “built-for-you” DE include tied to removed/migrated content. |
| bedrock/firefox/templates/firefox/browsers/mobile/ios.html | Removes Firefox sub-nav include from mobile iOS page. |
| bedrock/firefox/templates/firefox/browsers/mobile/index.html | Removes Firefox sub-nav include from mobile index page. |
| bedrock/firefox/templates/firefox/browsers/mobile/get-app.html | Removes Firefox sub-nav include from mobile get-app page. |
| bedrock/firefox/templates/firefox/browsers/mobile/focus.html | Removes Firefox sub-nav include from mobile focus page. |
| bedrock/firefox/templates/firefox/browsers/mobile/android.html | Removes Firefox sub-nav include from mobile Android page. |
| bedrock/firefox/templates/firefox/browsers/compare/index.html | Removes Firefox sub-nav include from compare page. |
| bedrock/firefox/redirects.py | Adds/adjusts offsite redirects to Firefox.com and AMO for migrated/removed paths. |
| bedrock/base/templates/includes/protocol/navigation/menus/products.html | Removes the Facebook Container product entry from top navigation. |
stephaniehobson
force-pushed
the
code-clean-up
branch
2 times, most recently
from
July 3, 2026 19:50
d630408 to
e03c09a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17264 +/- ##
==========================================
+ Coverage 82.71% 82.87% +0.16%
==========================================
Files 178 178
Lines 9318 9304 -14
==========================================
+ Hits 7707 7711 +4
+ Misses 1611 1593 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stephaniehobson
force-pushed
the
code-clean-up
branch
from
July 3, 2026 20:25
e03c09a to
5629302
Compare
stephaniehobson
marked this pull request as ready for review
July 3, 2026 20:28
Contributor
Author
|
@janriokrause This might completely pre-empt your #17263 🙈 |
stephaniehobson
force-pushed
the
code-clean-up
branch
from
July 3, 2026 20:54
5629302 to
6028b3a
Compare
stevejalim
reviewed
Jul 4, 2026
| return response | ||
| except Resolver404: | ||
| pass | ||
| return HttpResponsePermanentRedirect(f"{settings.FXC_BASE_URL}{request.get_full_path()}") |
Contributor
There was a problem hiding this comment.
do we want a querystring tag on here to knwo it was a redirect?
stephaniehobson
force-pushed
the
code-clean-up
branch
from
July 6, 2026 21:40
71c4faf to
ef5e7a0
Compare
Deletes templates, Fluent files, images, fonts, CSS/JS sources, and bundle entries for Firefox pages now served by www.firefox.com. Retained named URL routes pointing at a new fxc_redirect fallback view so existing template references remain reversible. Also removes the Firefox sub-navigation include from all remaining pages and cleans up related nav links and report references. Affected directories: - build-for-you - challenge-the-default - channel - compare - enterprise - facebookcontainer - family - features - firefox/more - mobile - nothing-personal - set-as-default
stephaniehobson
force-pushed
the
code-clean-up
branch
from
July 15, 2026 21:03
8cee450 to
ade4f52
Compare
janriokrause
left a comment
janriokrause
left a comment
Contributor
There was a problem hiding this comment.
Why are we keeping bedrock/firefox/templates/firefox/browsers/mobile/index.html (and its android/ios/focus/get-app siblings)?
The /firefox/browsers/mobile/ path is already 301'd to www.firefox.com/browsers/mobile/ (covered in test_redirects.py), so the template can never render. We are stripping the sub-nav include out of dead code, instead of deleting the template entirely.
If we drop the templates, we still need firefox.browsers.mobile.index to reverse for the callers we're not touching in this PR (sub-nav-firefox.html, faq.html, all/mobile.html, newsletter/updated.html, ctd-promo-de.html, plus the /exp/ entry in bedrock/base/redirects.py). Same pattern as firefox.notes / firefox.sysreq:
# bedrock/firefox/urls.py
# replace:
page("firefox/browsers/mobile/", "firefox/browsers/mobile/index.html", ftl_files=["firefox/browsers/mobile/index"]),
# with:
path("firefox/browsers/mobile/", views.fxc_redirect, name="firefox.browsers.mobile.index"),(and the same for .android, .ios, .focus, .get-app, .get-ios). RedirectsMiddleware still catches real traffic first, fxc_redirect is just the belt-and-braces fallback.
Any opinion on that? Is it going too far? Should this be done in a follow-up?
Contributor
Author
https://www.mozilla.org/en-US/firefox/browsers/mobile/get-app/ is still in use - from the analytics I'd guess there's a link in product somewhere. I thought it was safer to handle that directory separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Remove Firefox pages migrated to springfield 🪚
Significant changes and points to review
Affected directories:
Retained named URL routes pointing at a new fxc_redirect fallback view so existing template references remain reversible.
Also removes the Firefox sub-navigation include from all remaining pages and cleans up related nav links.
Issue / Bugzilla link
#16433
Testing
Integration tests: https://github.com/mozilla/bedrock/actions/runs/28681998285