Skip to content

docs(nimbus): Add rollout mermaid diagrams#16154

Merged
RJAK11 merged 4 commits into
mainfrom
16153
Jul 13, 2026
Merged

docs(nimbus): Add rollout mermaid diagrams#16154
RJAK11 merged 4 commits into
mainfrom
16153

Conversation

@RJAK11

@RJAK11 RJAK11 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Because

  • we need to add Mermaid diagrams reflecting the new rollout-specific state machine

This commit

  • adds the Mermaid diagrams for rollouts
  • updates timeout flows to return to idle after timeout

Fixes #16153

Because

* we need to add Mermaid diagrams reflecting the new rollout-specific state machine

This commit

* adds the Mermaid diagrams for rollouts
* updates timeout flows to return to idle after timeout

Fixes #16153
@RJAK11

RJAK11 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

During our diagram review meeting and local testing, we found that when a Remote Settings review times out, the owner has to request review again. Because of that, we updated the timeout flows to reflect this behavior. We may need to make the same kind of update to the experiment diagrams as well.

@yashikakhurana

Copy link
Copy Markdown
Contributor

Also worth noting that @freshstrangemusic mentioned that rollout pause only works for the labs, what will happen for non labs rollouts, will it keep the pause behaviour as expected that means users who are already enrolled will still enrolled, but no users will be enrolled 👀
cc @jaredlockhart and @freshstrangemusic

RJAK11 added 2 commits July 2, 2026 13:19
Because

* we need to add Mermaid diagrams reflecting the new rollout-specific state machine

This commit

* adds the Mermaid diagrams for rollouts
* updates timeout flows to return to idle after timeout

Fixes #16153
Because

* we need to add Mermaid diagrams reflecting the new rollout-specific state machine

This commit

* adds the Mermaid diagrams for rollouts
* updates timeout flows to return to idle after timeout

Fixes #16153
Comment thread docs/experimenter/rollouts.md Outdated
Because

* we need to add Mermaid diagrams reflecting the new rollout-specific state machine

This commit

* adds the Mermaid diagrams for rollouts
* updates timeout flows to return to idle after timeout

Fixes #16153
@RJAK11

RJAK11 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

I have switched all uses of <none> for None, changed all the Enable cases to have Phase Next: Phase X+1, and added the two cases for enabling with no next phase. Let me know if something seems off! 🙏🏼

@RJAK11
RJAK11 requested a review from jaredlockhart July 13, 2026 20:01

@jaredlockhart jaredlockhart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!! Looks great to me. Thank you so much for doing this @RJAK11. This will make implementation MUCH smoother and will act as a reference for a long time. Let's do it and then we can unblock #16097 🎉 🎉 🎉 🎉 🎉 🎉

@RJAK11
RJAK11 added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 4fe5d3b Jul 13, 2026
26 checks passed
@RJAK11
RJAK11 deleted the 16153 branch July 13, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollout Mermaid Diagrams Update

3 participants