Conversation
|
When testing locally with the "this is a rollout" checkbox checked, you'll hit 3 additional warnings not in the video for the population percent, total enrolled clients, and reference branch fields. A few thoughts on handling these:
Separately, we might need to bring over the AI risk field from the old UI into the new Risks card, and Public description into the Overview card or we can handle them the same way since we don’t currently have those fields. Let me know what you think! |
254cbe9 to
26798a0
Compare
* adds a setup completion progress bar to the rollout sidebar * adds an issues modal that lists invalid fields with links to the relevant card * allows rollouts to set 0% population, 0 enrolled clients, and no reference branch description * validates the rollout schedule (at least one phase, nonzero first phase) via NimbusRolloutReviewSerializer Fixes #15927
|
Update: instead of hard-coding some values to prevent the warnings mentioned previously, I added a dedicated NimbusRolloutReviewSerializer that the new UI uses (the old UI keeps the base serializer, so this is all scoped to the new UI). That clears the 3 warnings:
However, we may still want to add AI risk in the Risks card and Public description in the Overview card. |
# Conflicts: # experimenter/experimenter/nimbus_ui/templates/new/rollouts/audience/card.html # experimenter/experimenter/nimbus_ui/templates/new/rollouts/rollout_features/card.html # experimenter/experimenter/nimbus_ui/tests/test_new_views.py
Because * rollout authors need to know how much and what is left before a rollout can be launched This commit * adds a setup completion progress bar to the rollout sidebar * adds an issues modal that lists invalid fields with links to the relevant rollout card
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @RJAK11 this is really great, nice approach to use separate serializer, and I have tested it locally, majorly works fine, some improvements to make, otherwise very good work
Because * rollout authors need to know how much and what is left before a rollout can be launched This commit * adds a setup completion progress bar to the rollout sidebar * adds an issues modal that lists invalid fields with links to the relevant rollout card
Because
This commit
Fixes #15927
Screen.Recording.2026-07-08.at.3.01.38.PM.mov