Replace core2 with no_std_io2#407
Merged
vmx merged 3 commits intomultiformats:masterfrom Apr 15, 2026
Merged
Conversation
|
bro is doing god's work fixing all of the core2 usages |
Benten-Ben
added a commit
to BentenAI/rust-cid
that referenced
this pull request
Apr 15, 2026
core2 was archived upstream on 2026-04-14 ("No longer supported. Use
core directly."). core::io::{Read, Write} are not yet stable in Rust
(tracking issue rust-lang/rust#68315), so a direct migration is not
currently possible.
no_std_io2 0.8.1 is an API-compatible drop-in replacement for core2's
io module, purpose-built for crates that need the std::io trait shape
in no_std contexts.
This mirrors the approach taken in multiformats/rust-multihash#407
for multiformats org consistency.
Closes multiformats#184.
athola
suggested changes
Apr 15, 2026
athola
left a comment
athola
left a comment
There was a problem hiding this comment.
added minor nit comment, rest approved
vmx
approved these changes
Apr 15, 2026
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Thanks everyone involved! This is such a clean change now. Also thanks for checking out an older version of no_std_io2 to reduce the number of changes.
jxs
approved these changes
Apr 15, 2026
Contributor
|
@vmx can we release a patch version with this? So that we can unblock |
vmx
pushed a commit
to multiformats/rust-cid
that referenced
this pull request
Apr 15, 2026
core2 was archived upstream on 2026-04-14 ("No longer supported. Use
core directly."). core::io::{Read, Write} are not yet stable in Rust
(tracking issue rust-lang/rust#68315), so a direct migration is not
currently possible.
no_std_io2 0.8.1 is an API-compatible drop-in replacement for core2's
io module, purpose-built for crates that need the std::io trait shape
in no_std contexts.
This mirrors the approach taken in multiformats/rust-multihash#407
for multiformats org consistency.
The dependencies that also had this `no_std_io2` change were also
explicitly updated to the corresponding versions.
Closes #184.
elenaf9
reviewed
Apr 15, 2026
4 tasks
SWvheerden
pushed a commit
to tari-project/tari
that referenced
this pull request
Apr 17, 2026
Description --- chore: update multiaddr (core2 yanked) Motivation and Context --- All versions of `core2` were yanked. When packages use tari_common they will fail to build with a fresh cargo.lock. We see this on Ootle packages (and we can't publish them). multihash has been updated to use `no_std_io2` instead (multiformats/rust-multihash#407) - multihash is a dep of multiaddr Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
0xskr33p
pushed a commit
to 0xskr33p/tari
that referenced
this pull request
Apr 19, 2026
Description --- chore: update multiaddr (core2 yanked) Motivation and Context --- All versions of `core2` were yanked. When packages use tari_common they will fail to build with a fresh cargo.lock. We see this on Ootle packages (and we can't publish them). multihash has been updated to use `no_std_io2` instead (multiformats/rust-multihash#407) - multihash is a dep of multiaddr Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core2was yanked a couple of hours ago. This MR removes the dependency in favor ofno_std_io2.