This repository was archived by the owner on May 26, 2022. It is now read-only.
Do not look for goog.provide/require in comments#46
Open
lexoyo wants to merge 1 commit intomxmul:masterfrom
Open
Do not look for goog.provide/require in comments#46lexoyo wants to merge 1 commit intomxmul:masterfrom
lexoyo wants to merge 1 commit intomxmul:masterfrom
Conversation
This is a workaround for the issue mxmul#16 "Incorrectly finds `goog.require` and `goog.provide` statements in comments"
mxmul
suggested changes
Mar 24, 2019
Owner
mxmul
left a comment
mxmul
left a comment
There was a problem hiding this comment.
Thanks for the PR! Stripping out the comments seems like a good approach.
It looks like the test suite is failing however – could you fix that, and add some regression tests for this change?
| let source = originalSource; | ||
| let source = originalSource | ||
| //.replace(/\/\/.*/g, '') // remove line comments (somehow this bugs) | ||
| .replace(/\/\*[^]*?\*\//g, '/* stripped comment */'); // block comments |
Owner
There was a problem hiding this comment.
Is [^]* equivalent to .*? More readable as the latter if so
Author
There was a problem hiding this comment.
Hi
I just took people comments and made a PR. I was not even sure that you would answer. Now that I know I will take the time to understand and fix everything :)
Thank you for your feedback
| const callback = this.async(); | ||
| let source = originalSource; | ||
| let source = originalSource | ||
| //.replace(/\/\/.*/g, '') // remove line comments (somehow this bugs) |
Owner
There was a problem hiding this comment.
Seems like this would strip everything in the source file after the first comment. You probably only want to match until EOL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue #16 "Incorrectly finds
goog.requireandgoog.providestatements in comments"