Improve smart threading for HTTPS URLs with pushurl#69
Merged
Conversation
- HTTPS URLs with pushurl are now processed in parallel - pushurl indicates the HTTPS URL is read-only/public - Improves performance for common public repo pattern - Backward compatible, no breaking changes Changes: - Updated _separate_https_packages() to check for pushurl - HTTPS+pushurl packages now go to parallel queue - HTTPS-only packages still go to serial queue (credential prompts) - Added comprehensive test coverage - Updated documentation in README.md Performance benefit: Packages with pattern like: url = https://github.com/org/repo.git (public read) pushurl = git@github.com:org/repo.git (authenticated write) are now processed in parallel instead of serially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves smart threading performance by processing HTTPS URLs with
pushurlin parallel instead of serially.Problem
Currently, all HTTPS URLs are processed serially to avoid overlapping credential prompts. This is overly conservative for packages that define both:
url = https://github.com/org/repo.git(public read)pushurl = git@github.com:org/repo.git(authenticated write)These HTTPS URLs won't prompt for credentials (they're read-only/public), so they should be safe to process in parallel.
Solution
Updated
_separate_https_packages()to check forpushurlpresence:Benefits
✅ Performance: Common public repo pattern now processed in parallel
✅ Backward Compatible: No breaking changes, purely optimization
✅ Smart: Leverages semantic meaning of pushurl configuration
Changes
src/mxdev/vcs/common.py: Updated_separate_https_packages()logictests/test_git_additional.py: Addedtest_smart_threading_separates_https_with_pushurl()CHANGES.md: Documented performance improvementREADME.md: Updated Smart Threading documentationTesting
Example Configuration