Skip to content

Conversation

@cstuncsik
Copy link
Contributor

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

… for consistency and improved functionality across components
@bundlemon
Copy link

bundlemon bot commented Dec 4, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
11.45MB (+159.62KB +1.38%) -
**/*.css
235.14KB (+14.36KB +6.5%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 89.81670% with 50 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ystem/src/components/N8nPopover/Popover.stories.ts 0.00% 46 Missing ⚠️
...itor-ui/src/app/components/MainSidebarUserArea.vue 0.00% 2 Missing ⚠️
...onents/ResourceLocator/ResourceLocatorDropdown.vue 97.72% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 4, 2025
@currents-bot
Copy link

currents-bot bot commented Dec 4, 2025

E2E Tests: n8n tests passed after 6m 28s

🟢 265 · 🔴 0 · ⚪️ 15 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 1

  • Framework: Playwright

  • Run Status: Passed

  • Commit: d80615f

  • Spec files: 120

  • Overall tests: 558

  • Duration: 6m 28s

  • Parallelization: 4


This message was posted automatically by currents.dev | Integration Settings

@blacksmith-sh

This comment has been minimized.

… for improved interaction and clarity; refactor CanvasNodeToolbar and CanvasNodeStickyColorSelector tests for better structure and functionality
…s for improved sticky note color selection and interaction
@blacksmith-sh

This comment has been minimized.

@blacksmith-sh

This comment has been minimized.

cstuncsik and others added 2 commits December 5, 2025 18:38
… selectors

During N8nPopover migration, E2E tests need selectors that match both
Element+ (.el-popper) and Reka UI ([data-state="open"]) popover content.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@cstuncsik cstuncsik marked this pull request as ready for review December 5, 2025 19:47
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 32 files

@blacksmith-sh

This comment has been minimized.

Resolved conflict in ResourceLocatorDropdown.vue:
- Kept Reka UI N8nPopover with #trigger and #content slots
- Incorporated master's slow load notice feature
Resolved conflicts:
- MainSidebar.vue: Use N8nPopover instead of N8nPopoverReka for Help and Settings popovers
- ResourceLocatorDropdown.vue: Incorporate master's disableInactiveItems prop, updated onItemClick signature, and item-badge slot while keeping N8nPopover

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants