feat:GoogleCalendarにイベントを追加するコマンド #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review suggestion change envname Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Member
Author
|
@chun37 レビュー感謝 |
chun37
requested changes
Aug 9, 2020
Member
chun37
left a comment
chun37
left a comment
There was a problem hiding this comment.
良くなったと思う。
あと import のソートもお願いしたいです。
Member
|
Web Request についてだけど、requests を入れるか urllib.request を使うかどちらが良いのだろう |
Merged
Co-authored-by: chun <[email protected]>
Member
Author
現状ここでしかhttp requestしないから標準ライブラリでいいかなと |
WEBHOOKを自作のものに変更
Member
Author
|
@chun37 |
chun37
reviewed
Aug 12, 2020
Member
chun37
left a comment
chun37
left a comment
There was a problem hiding this comment.
コードの内容的には問題無いと思う。
引数が多いのどうにかしたいと思った。
今後も増えたり減ったりする可能性あるし、dataclass とか使えばいいかなと思った。
どう？
chun37
reviewed
Aug 13, 2020
chun37
reviewed
Aug 13, 2020
Member
|
GoogleCalenderImpl を使ってるので、CalenderImpl の必要ってあるのかな |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CALENDAR_WEBHOOKはIFTTTのもの