Skip to content

fix: add domain.name indexes to subgraph schema #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shrugs wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

fix: add domain.name indexes to subgraph schema #1856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ensdb-sdk/src/ensindexer-abstract/subgraph.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ export const subgraph_domain = onchainTable(
expiryDate: t.bigint(),
}),
(t) => ({
// Temporarily disable the `byName` index to avoid index creation issues.
// For more details, see: https://github.com/namehash/ensnode/issues/1819
// byName: index().on(t.name),
// uses a hash index because some name values exceed the btree max row size (8191 bytes)
Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrugs Hey, I note that the PR @tk-o was working on to add initializeIndexingSetup has been merged now in #1843.

What do you think about exploring how we might add logic in that function to activate the pg_trgm extension in Postgres?

If we do this now:

  • Suggest to add some extra docs somewhere in ensdb-sdk talking about this extension.

If on the other hand we don't do this now:

  • Suggest to create a follow-up issue to log this opportunity.

Appreciate your advice 👍

byExactName: index().using("hash", t.name),
Copy link
Copy Markdown
Contributor

@vercel vercel bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
byExactName: index().using("hash", t.name),
byExactName: index().using("hash").on(t.name),

Incorrect hash index syntax: index().using("hash", t.name) passes column as second parameter instead of using .on() method

Fix on Vercel


byLabelhash: index().on(t.labelhash),
byParentId: index().on(t.parentId),
byOwnerId: index().on(t.ownerId),
Expand Down
Loading