-
Notifications
You must be signed in to change notification settings - Fork 51
Update scripts to pydantic v2 #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Czaki since we needed to modify this anyways, I also removed the dependency on |
|
This depends on the napari PR right? so we need to merge that to unbreak CI in this PR? |
|
Yeah we're in a bit of a loop here I think 😅 |
|
We might think about moving part of these scripts to the main repository. Or just do cross checks against PRs and do do yolo merge |
|
I think if we check locally that docs build with the branch from napari/napari#8509 then it's fine to merge this as is - but maybe we merge it when #8509 is also close so that we don't have docs broken for a long time? |
melissawm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds fine locally with the branch indicated above, so LGTM! But I agree we should wait and not break the docs build.
References and relevant issues
Description
Updating the scripts to work with pydantic v2.