Skip to content

Conversation

@brisvag
Copy link
Contributor

@brisvag brisvag commented Feb 5, 2026

References and relevant issues

Description

Updating the scripts to work with pydantic v2.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 5, 2026
@brisvag
Copy link
Contributor Author

brisvag commented Feb 5, 2026

@Czaki since we needed to modify this anyways, I also removed the dependency on napari._pydantic_compat, so I think we can remove that from there as well?

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Feb 5, 2026

This depends on the napari PR right? so we need to merge that to unbreak CI in this PR?
Of course that means docs builds will be broken in the napari PR until this is merged?
🥶

@brisvag
Copy link
Contributor Author

brisvag commented Feb 5, 2026

Yeah we're in a bit of a loop here I think 😅

@Czaki
Copy link
Contributor

Czaki commented Feb 5, 2026

We might think about moving part of these scripts to the main repository.

Or just do cross checks against PRs and do do yolo merge

@DragaDoncila
Copy link
Contributor

I think if we check locally that docs build with the branch from napari/napari#8509 then it's fine to merge this as is - but maybe we merge it when #8509 is also close so that we don't have docs broken for a long time?

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine locally with the branch indicated above, so LGTM! But I agree we should wait and not break the docs build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants