Skip to content

fix(pack-release): make tag-paths optional for charts without first-party images #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viniciusdc merged 1 commit into from
Jul 22, 2026
Merged

fix(pack-release): make tag-paths optional for charts without first-party images #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/pack-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ on:
release's sha-<short-sha> tag, for example:
operator.image.tag
worker.image.tag
required: true
Optional. Charts that don't ship first-party images (e.g. charts
that only reference third-party base images) can omit this or
pass an empty string.
required: false
default: ""
type: string
secrets:
NEBARI_HELM_REPO_TOKEN:
Expand Down Expand Up @@ -165,10 +169,14 @@ jobs:

short_sha="${GITHUB_SHA::7}"
mapfile -t paths < <(printf '%s\n' "$TAG_PATHS" | sed '/^[[:space:]]*$/d')
echo "Pinning ${#paths[@]} path(s) to sha-${short_sha}: ${paths[*]}"

python3 _dot-github/.github/scripts/pin_image_tags.py \
"${CHART_PATH}/values.yaml" "sha-${short_sha}" "${paths[@]}"
if [ "${#paths[@]}" -eq 0 ]; then
echo "No tag paths configured — skipping image tag pinning"
else
echo "Pinning ${#paths[@]} path(s) to sha-${short_sha}: ${paths[*]}"
python3 _dot-github/.github/scripts/pin_image_tags.py \
"${CHART_PATH}/values.yaml" "sha-${short_sha}" "${paths[@]}"
fi

- name: Set up Helm
if: steps.exists.outputs.exists == 'false'
Expand Down