fix(rbac): derive HUB_EXTERNAL_URL via the hubExternalURL helper#186
Open
tylerpotts wants to merge 1 commit into
Open
fix(rbac): derive HUB_EXTERNAL_URL via the hubExternalURL helper#186tylerpotts wants to merge 1 commit into
tylerpotts wants to merge 1 commit into
Conversation
The bootstrap job rendered HUB_EXTERNAL_URL from nebariapp.hostname
raw, unlike every other consumer, which goes through the hubHostname /
hubExternalURL helpers (deriving hub.<base-domain> from
keycloak.hostname). On zero-config deploys the env var therefore
rendered as 'https://'; the script's rstrip('/') reduced it to
'https:', which passed the if-not-hub_external_url guard, and Keycloak
400'd the hub client-URL reconcile - crashlooping the Job on every
deployment that relies on hostname derivation.
Fixes #185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185.
Problem
The RBAC bootstrap Job renders
HUB_EXTERNAL_URLfrom.Values.nebariapp.hostnamedirectly, unlike every other consumer which goes through thehubHostname/hubExternalURLhelpers (derivinghub.<base-domain>fromkeycloak.hostname). On zero-config deploys the env var renders ashttps://; the script'srstrip('/')reduces it tohttps:, which passes theif not hub_external_urlguard, and Keycloak 400s the hub client-URL reconcile — the Job crashloops on every deployment that relies on hostname derivation (observed on a Hetzner k3s deployment; log signaturereconciling hub client URLs (rootUrl='https:', ...)).Fix
One line: default to
include "nebari-data-science-pack.hubExternalURL" . | trimSuffix "/"instead ofprintf "https://%s" .Values.nebariapp.hostname. The helper returns empty when no hostname is derivable, so the script's skip-guard actually engages.Rendering matrix (verified with helm template)
keycloak.hostnameonlyhttps://-> 400 crashloophttps://hub.<base-domain>nebariapp.hostnamehttps://<hostname>rbac.bootstrap.hubExternalUrlnebariapp.enabled=falsethe Job is not rendered at allhelm lintpasses.