Makefile: General improvements#197
Open
asiekierka wants to merge 3 commits into
Open
Conversation
koitsu
reviewed
Jul 2, 2026
|
|
||
| ifeq ($(MESENOS),osx) | ||
| LINKOPTIONS += -framework Foundation -framework Cocoa -framework GameController -framework CoreHaptics -Wl,-rpath,/opt/local/lib | ||
| CXXFLAGS += -fPIC -Wall --std=c++17 $(SDL2INC) -I $(realpath ./) -I $(realpath ./Core) -I $(realpath ./Utilities) -I $(realpath ./Sdl) -I $(realpath ./Linux) -I $(realpath ./MacOS) |
There was a problem hiding this comment.
Why are you using realpath here? What functional purpose does this serve?
And you do know on some OSes (ex. OS X), realpath is not available, yes?
Author
There was a problem hiding this comment.
That code was already there (see a few lines below in the diff) and it has successfully built Mesen on macOS for the past few years, so...
There was a problem hiding this comment.
Sorry about that -- yeah, I missed the part of the (removal/relocation) part of the diff. Really don't know why any of that is there. Thanks for answering / correcting me though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows defining user-provided CFLAGS/CXXFLAGS/LDFLAGS, as well as an
installtarget with DESTDIR and PREFIX variables.However, there's some work on the UI side that has to be done before I'd consider official installing on Linux to be viable:
access()) - if not, it should hide the radio button option to change the configuration path..desktopfile to configure file associations, but the same.desktopfile is also used to provide a desktop/application menu icon after installation. It would be better if it had a command-line option to generate a.desktopfile that a package manager (ormake install) could then install globally, system-wide; and, ideally, if MesenCE checked for the existence of such a file and did not install one locally if so.