adding conditional to claim rooms #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
approved these changes
Feb 7, 2025
Member
ilyam8
left a comment
ilyam8
left a comment
There was a problem hiding this comment.
Whether 'NETDATA_CLAIM_ROOMS' is empty or not defined, the outcome will be the same. Wil it not?
witalisoft
approved these changes
Feb 7, 2025
Contributor
Author
|
yup, it will land in the all nodes room. This way you just do not have to do the empty string of some sort when you do not need this value at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have dynamic rooms it makes sense for this parameter to be optional.