-
Notifications
You must be signed in to change notification settings - Fork 81
Add Startup Volume Permission Enforcement #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR Could you tell us what kind of use case it solves ? btw there are some files inside the containers that are bound to that builtin user netdata (uid: 201) |
|
@witalisoft I can't speak for the original author of #449, but my use-case is that I am running Netdata on an AWS EFS backed volume. If the U/ID of the container (201) does not match the ID of the filesystem, the Netdata process quits when it tries to I cannot definitively say what effect might be for those specified files, but I have been running these changes in my cluster for the last day with seemingly normal operation. |
|
@theeternalrat So what I would prefer is to put the placeholder for the ...
{{ toYaml .Values.parent.extraInitContainers | indent 8 }}
containers:
...Now you get the flexibility, and we're not stuck with another use case for testing the helm chart. The rest of what you presented like |
|
@witalisoft I've made the requested change. It'll now be up to the user to defined their own volume-permissions container if they so choose. |
M4itee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Thanks @theeternalrat
Resolves #449 . This ads the ability run the parent pod as a select uid/gid, and run an init container that will set file permissions appropriately on the mounted directories.