Skip to content

Conversation

@ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Aug 8, 2025

This PR fixes duplicate metrics collection from kubelet by aligning the static job names in our Helm chart with the dynamic job names used by the locallisteners discoverer.

We were collecting metrics from kubelet twice:

  • Once through the static k8s_kubelet job defined in our Helm chart
  • Once through the dynamic local job discovered by the locallisteners discoverer

Both jobs were running simultaneously because they had different names, resulting in duplicate metrics.

@ilyam8 ilyam8 requested review from a team as code owners August 8, 2025 09:46
@ilyam8 ilyam8 requested review from M4itee and witalisoft August 8, 2025 09:46
@ralphm
Copy link
Member

ralphm commented Aug 8, 2025

This looks good to me. We should note somewhere that this canl cause the "loss" of a job.

@witalisoft
Copy link
Contributor

good catch

@ilyam8
Copy link
Member Author

ilyam8 commented Aug 8, 2025

This looks good to me. We should note somewhere that this canl cause the "loss" of a job.

The proper fix would be removing these static jobs from the Helm chart entirely, as the locallisteners discoverer creates identical jobs automatically. However, we need to verify that discovery works correctly for both kubelet (this one is more or less confirmed) and kubeproxy before making that change.

@ilyam8 ilyam8 merged commit 6e2b855 into netdata:master Aug 8, 2025
3 checks passed
@ilyam8 ilyam8 deleted the add-kubelet-kubeproxy-job-name branch August 8, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants