Skip to content

feat: timeline-event check for old-head review + CLEAN merge decisions#66

Merged
CybotTM merged 2 commits into
mainfrom
feat/timeline-review-check
Jun 12, 2026
Merged

feat: timeline-event check for old-head review + CLEAN merge decisions#66
CybotTM merged 2 commits into
mainfrom
feat/timeline-review-check

Conversation

@CybotTM

@CybotTM CybotTM commented Jun 12, 2026

Copy link
Copy Markdown
Member

Companion to the arming gate and the 'never merge over an announced review' rule: after a follow-up push, the only review on record may sit on the previous commit while mergeStateStatus reports CLEAN off it (a review_on_push: false ruleset). reviewRequests: [] and the reviews list cannot distinguish 'no new review will come' from 'one is in flight'.

The new subsection documents the deciding query — the issue timeline's review_requested/reviewed events compared against the latest push time — and both outcomes. Used three times during the nr-repurpose v0.1.0 release day (2026-06-12), incl. a docs-only push that did not re-trigger Copilot.

Eval old_head_review_clean_timeline_check added.

A follow-up push (docs-only changes often do not re-trigger Copilot)
leaves the only review on a previous commit while the ruleset reports
CLEAN off it. The reviews list and reviewRequests cannot say whether a
new review was announced after the push - the issue timeline can.
Document the review_requested/reviewed timeline query and the two
outcomes (no announcement after the push = mergeable; announcement
without a landed review = wait). Applied three times during the
nr-repurpose v0.1.0 release day. Adds eval
old_head_review_clean_timeline_check.

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Copilot AI review requested due to automatic review settings June 12, 2026 10:13
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new evaluation test case and updates the documentation to detail how to determine mergeability when a review exists on an earlier commit head and the status is CLEAN. The reviewer suggested replacing the OWNER/REPO placeholder in the GitHub CLI command with an explicit repository variable ($R) to ensure compatibility outside the local git context.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread skills/git-workflow/references/pull-request-workflow.md Outdated
…ge-gate style)

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
@sonarqubecloud

Copy link
Copy Markdown

@CybotTM CybotTM merged commit decb270 into main Jun 12, 2026
17 checks passed
@CybotTM CybotTM deleted the feat/timeline-review-check branch June 12, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants