Fix mingw build (only)#4
Merged
jimklimov merged 10 commits intonetworkupstools:rtu_usbfrom Jan 26, 2025
Merged
Conversation
Also define WARNING_CXXFLAGS even if not used at the moment; the script already does juggle CXXFLAGS and detects PROG_CXX anyway. Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…ds (mingw) Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…ntop() from NUT for cross-builds on WIN32 (mingw) Adapted to libmodbus codebase and clang-format Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…uires netinet/in.h explicitly included first Looking at FreeBSD, OpenIndiana et al. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e-bracket debug printout Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…, report it as such (not as generic "select()") Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…f() to sync the output Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tuations Signed-off-by: Jim Klimov <jimklimov@gmail.com>
This was referenced Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from PR #3 that also tries to fix tests and code, and may take more time to complete through all the questionable changes into production code (e.g. flushing or not upon reconnection attempts).
This subset of those changes focuses more strictly on passing builds without warnings, due to regressions allegedly due to upstream v3.1.10->v3.1.11 bump, so these fixes could be up-streamed separately:
rtu_usbbranch not as portable as they should be (printing of int types)setsockopt()pointer to datainet_ntop()/inet_pton()absent on Windows (at least MINGW on Linux cross-build environments, MSYS2 does not seem to suffer this one) -configuredetection and fallback implementation code imported from NUTip.hneedsin.hexplicitly on some platformsEnhancements:
./configure --enable-Werrorin test builds, to fail the build upon any compiler warnings (not enabled by default), allowing to easily iterate on the code fixes