One-Click Postage: Restore functionality on accounts with new footer variant #2195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This restores basic One-Click Postage functionality on accounts with one of Tumblr's new post footer tests.
XKit Rewritten's Quick Reblog has already had a number of fixes for this footer variant (as well as another one). For reference, I squashed them here: AprilSylph/XKit-Rewritten@728fd65. Most of these fixes are for things that don't even work in this project currently, though.
AlreadyReblogged in particular does not currently work (as noted in #2098), so I did not fix it here. It is, it should be noted, fairly annoying to fix.
For consistency with this repository's norms, particular consideration must be made to browser compatibility; New XKit supports older browser versions that do not support
:has()selectors.Testing steps
Conform that, on an account without the new post footer:
Conform that, on an account with the latest new post footer:
XKit team members, message me if you want to test this and don't have accounts both with and without the relevant flag.