feat: Add live updates for remaining time in menu#241
Open
bryanvrgsc wants to merge 1 commit intonewmarcel:mainfrom
Open
feat: Add live updates for remaining time in menu#241bryanvrgsc wants to merge 1 commit intonewmarcel:mainfrom
bryanvrgsc wants to merge 1 commit intonewmarcel:mainfrom
Conversation
- Add NSTimer to update remaining time every second - Use NSRunLoopCommonModes so timer fires while menu is open - Implement menuWillOpen: and menuDidClose: delegates - Timer starts when menu opens, stops when menu closes The timer must use NSRunLoopCommonModes because the menu tracking uses NSEventTrackingRunLoopMode, not the default mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timer must use NSRunLoopCommonModes because the menu tracking uses NSEventTrackingRunLoopMode, not the default mode.