Skip to content

fix(FilePicker): reset filter string when navigating #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max65482 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(FilePicker): reset filter string when navigating #2384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/components/FilePicker/FilePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@ const currentPath = computed({
*/
const selectedFiles = shallowRef<INode[]>([])

/**
* A string used to filter files in current view
*/
const filterString = ref('')

const {
files,
folder: currentFolder,
Expand All @@ -208,6 +213,8 @@ watch([navigatedPath], () => {
}
// Reset selected files
selectedFiles.value = []
// Reset filter string
filterString.value = ''
})

/**
Expand Down Expand Up @@ -257,11 +264,6 @@ async function handleButtonClick(callback: IFilePickerButton['callback'], nodes:
*/
const viewHeadline = computed(() => currentView.value === 'favorites' ? t('Favorites') : (currentView.value === 'recent' ? t('Recent') : ''))

/**
* A string used to filter files in current view
*/
const filterString = ref('')

const { isSupportedMimeType } = useMimeFilter(toRef(props, 'mimetypeFilter')) // vue 3.3 will allow cleaner syntax of toRef(() => props.mimetypeFilter)

onMounted(() => loadFiles())
Expand Down