Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16117.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@PhilLab
Copy link
Contributor

PhilLab commented Jan 4, 2026

@tobiasKaminsky it is only a small piece of the puzzle, but when extending tests for another PR, I noticed that this will be necessary to fix the screenshot tests on master as well: 55acbba (part of #16215). Cherry-pick it, if you like.

When executing locally, the test did still fail, because one of the icons changed from filled to outline. I didn't touch the reference screenshots, because I wasn't sure what the expected style actually is:
image

@AndyScherzinger
Copy link
Member

Hi @PhilLab,

to answer the question, we switched to outline, so updating the reference screenshot is correct 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants