Skip to content

fix(AppDisableListener): pass full provider key to deleteProvider #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyteinsky merged 1 commit into from
Aug 13, 2026
Merged

fix(AppDisableListener): pass full provider key to deleteProvider #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Listener/AppDisableListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ public function handle(Event $event): void {
}

$this->providerConfig->removeProvider($appId, $providerId);
$this->actionService->deleteProvider($providerId);
// deleteProvider() expects the full provider key (appId__providerId),
// not the bare provider id; $key already holds that full key.
$this->actionService->deleteProvider($key);
}
}
}
5 changes: 4 additions & 1 deletion lib/Service/ActionScheduler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ public function deleteSources(array $sourceIds): void {
}

/**
* @param string $providerKey
* @param string $providerKey The full provider key in the form appId__providerId
* (e.g. "mail__mail"), as returned by
* ProviderConfigService::getConfigKey(). Passing a bare
* provider id makes the backend reject the whole action batch.
* @return void
* @throws Exception
*/
Expand Down
Loading