feat(tray): move logout and remove to settings menu#10165
Conversation
Signed-off-by: Rello <github@scherello.de>
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4608a9ef94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Rello <github@scherello.de>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aceda087d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (_accountState->isConnected()) { | ||
| userModel->logout(userId); | ||
| } else { | ||
| userModel->login(userId); |
There was a problem hiding this comment.
When an account is in a non-connected but still signed-in state such as NetworkError, ServiceUnavailable, or NeedToSignTermsOfService, this branch calls login() because isConnected() is false. AccountState::signIn() only transitions from SignedOut, so the new settings button becomes a no-op in those states instead of letting the user log out and clear credentials; please preserve the old isSignedOut() distinction for choosing login versus logout.
Useful? React with 👍 / 👎.
…tead of isConnected() Signed-off-by: Rello <github@scherello.de>
|
Artifact containing the AppImage: nextcloud-appimage-pr-10165.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
1 participant
the user logout and remove are moved from the tray window user menu into the user settings