feat(ui): numeric count badge replaces dot indicator#2963
Draft
karlitschek wants to merge 1 commit intomasterfrom
Draft
feat(ui): numeric count badge replaces dot indicator#2963karlitschek wants to merge 1 commit intomasterfrom
karlitschek wants to merge 1 commit intomasterfrom
Conversation
The bell icon now shows a numeric badge (capped at "99+") when there are notifications, instead of the previous solid dot. The dot is kept for the warning and pending-permission states. The badge re-keys on every count change so the pop animation re-fires whenever a new notification arrives. * IconNotification.vue: count prop with default 0; renders the dot SVG only when warning or pending-permission, the plain bell + badge otherwise * NotificationsApp.vue: passes notifications.length as :count * styles.scss: badge styling and badge-pop keyframe Signed-off-by: Frank Karlitschek <frank@nextcloud.com>
Member
|
We don't expose the full number of notifications atm, so this needs more work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bell icon now shows a numeric badge (capped at "99+") when there are notifications, instead of the previous solid dot. The dot is kept for the warning and pending-permission states. The badge re-keys on every count change so the pop animation re-fires whenever a new notification arrives.