Skip to content

[stable34] feat(core): app menu polish for NC34#60358

Open
pringelmann wants to merge 1 commit into
masterfrom
fix/59888/waffle-menu-p2-polish
Open

[stable34] feat(core): app menu polish for NC34#60358
pringelmann wants to merge 1 commit into
masterfrom
fix/59888/waffle-menu-p2-polish

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

@pringelmann pringelmann commented May 13, 2026

Summary

Two follow-ups to #60180:

  • Grid padding moves to the popover wrapper so the top-row hover sits inside the rounded corner.
  • Admin pages (Settings, Apps, Accounts, Help) showed an empty current-app slot. Those entries register as type=settings so they're excluded from the apps initial state. Falls back to settingsNavEntries when no app is active. Logout filtered out defensively.

Preview link

Aria-label includes the section name so screen readers match the visible text, and settings icons are force-whitened since they ship dark and would otherwise be invisible on the themed header.

Three unit tests cover the fallback path.

Also attempted to unify the two triggers visually. Three approaches, none clean enough before freeze. Parking for a post-NC34 design pass.

Checklist

@pringelmann pringelmann marked this pull request as ready for review May 15, 2026 10:43
@pringelmann pringelmann requested a review from a team as a code owner May 15, 2026 10:43
@pringelmann pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team May 15, 2026 10:43
@pringelmann pringelmann self-assigned this May 15, 2026
@pringelmann pringelmann added the 3. to review Waiting for reviews label May 15, 2026
@pringelmann pringelmann added this to the Nextcloud 34 milestone May 15, 2026
@pringelmann pringelmann added design Design, UI, UX, etc. enhancement labels May 15, 2026
@pringelmann pringelmann requested a review from kra-mo May 15, 2026 10:51
@pringelmann pringelmann changed the base branch from master to stable34 May 15, 2026 10:51
@pringelmann pringelmann force-pushed the fix/59888/waffle-menu-p2-polish branch from 261f82e to 28d8451 Compare May 15, 2026 10:52
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding actually looks worse now, since scrolling clips:

image

What I meant with my previous comment on padding was that, when hovered, it would be nice if these would be identical:

image

And the way to achieve that would be to increase the top padding of each item in the top row. I can also let go of this request if it would be too messy to do, it's just a small thing.

The colors also seem to be broken on the preview, I'm not sure what causes that, or whether it's relevant.

image

@github-actions github-actions Bot changed the title feat(core): app menu polish for NC34 [stable34] feat(core): app menu polish for NC34 May 15, 2026
@susnux
Copy link
Copy Markdown
Contributor

susnux commented May 15, 2026

The colors also seem to be broken on the preview, I'm not sure what causes that, or whether it's relevant.

Also wonder where the icons coming from, e.g. the app icon for activity is a lightning not a key.

@pringelmann
Copy link
Copy Markdown
Contributor Author

@kra-mo I had to reset my local env, so I didn't test scrolling behavior before opening PR. Will make sure to check the preview env next time!

Yeah it's a small thing but I feel its important to get the small details right on such a fundamental element change, so I fixed it. Please check the preview link again.

The dark/colored icons are from fake apps that I installed to quickly populate the menu. I've colored the icons correctly.

Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you :)

@pringelmann pringelmann changed the base branch from stable34 to master May 15, 2026 14:51
@pringelmann pringelmann requested a review from a team as a code owner May 15, 2026 14:51
@pringelmann pringelmann requested review from ArtificialOwl and salmart-dev and removed request for a team May 15, 2026 14:51
@pringelmann
Copy link
Copy Markdown
Contributor Author

/backport to stable34

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the fix/59888/waffle-menu-p2-polish branch from 72d7e31 to 5a9e63c Compare May 15, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request design Design, UI, UX, etc. enhancement

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants