[stable34] feat(core): app menu polish for NC34#60358
Conversation
261f82e to
28d8451
Compare
kra-mo
left a comment
There was a problem hiding this comment.
The padding actually looks worse now, since scrolling clips:
What I meant with my previous comment on padding was that, when hovered, it would be nice if these would be identical:
And the way to achieve that would be to increase the top padding of each item in the top row. I can also let go of this request if it would be too messy to do, it's just a small thing.
The colors also seem to be broken on the preview, I'm not sure what causes that, or whether it's relevant.
Also wonder where the icons coming from, e.g. the app icon for activity is a lightning not a key. |
|
@kra-mo I had to reset my local env, so I didn't test scrolling behavior before opening PR. Will make sure to check the preview env next time! Yeah it's a small thing but I feel its important to get the small details right on such a fundamental element change, so I fixed it. Please check the preview link again. The dark/colored icons are from fake apps that I installed to quickly populate the menu. I've colored the icons correctly. |
|
/backport to stable34 |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
72d7e31 to
5a9e63c
Compare



Summary
Two follow-ups to #60180:
type=settingsso they're excluded from theappsinitial state. Falls back tosettingsNavEntrieswhen no app is active. Logout filtered out defensively.Preview link
Aria-label includes the section name so screen readers match the visible text, and settings icons are force-whitened since they ship dark and would otherwise be invisible on the themed header.
Three unit tests cover the fallback path.
Also attempted to unify the two triggers visually. Three approaches, none clean enough before freeze. Parking for a post-NC34 design pass.
Checklist